GTK3 port: xfce4-mailwatch-plugin

[Simon Steinbeiss]

Hi Xoán,

it's been a while since your initial message and Matthew's response. I
briefly tested the plugin and the port to Gtk3 indeed seems complete and
the plugin seems to be working ok.

Are you willing to take a look at the remaining gcrypt issue? Also, I'd be
happy to merge your work to the master branch of the plugin and give you
access to it on git.xfce.org if you're interested in maintaining it.
Please let me know!

Cheers
Simon


On Fri, Jan 18, 2019 at 12:14 AM Matthew Brush <mbrush at codebrainz.ca> wrote:

> On 2019-01-17 2:39 a.m., Xoán Sampaíño wrote:
> > Hi,
> >
> > I'm Xoan, from Spain (currently living in Morocco), and I've been using
> > Xfce from a long time ago. I've done some translation contributions in
> the
> > past, and now I'm trying to get involved by doing some «small» coding
> tasks.
> >
> > I'm porting xfce4-mailwatch-plugin to GTK3:
> >
> > * https://github.com/xoan/xfce4-mailwatch-plugin/tree/gtk3
> >
> > You can try it by cloning the fork, changing to gtk3 branch and
> > compile/install it as usual.
> >
> > The current list of commits/changes:
> >
> > *
> >
> https://github.com/xfce-mirror/xfce4-mailwatch-plugin/compare/master...xoan:gtk3?w=1
> >
> > GTK3 port seems to be complete (no warnings), so I'm trying to fix some
> > Glib deprecation warnings.
> >
> > Most of them seem to be fixed, but there are still some (in
> > libmailwatch-core/mailwatch-net-conn.c) that I don't know how to handle
> > them.
> >
> > Any feedback, comment and/or help is very welcome.
> >
>
> Hi,
>
> It looks like the code is using older libgcrypt but you're compiling
> against newer version. In the newer version, that structure
> `gcry_threads_cbs` is totally different[0]. I guess you'd also have to
> port the libgcrypt to use the newer version as well, or compile it
> against the older deprecated version.
>
> Regards,
> Matthew Brush
>
> [0]: https://github.com/gpg/libgcrypt/blob/master/src/gcrypt.h.in#L211
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20191104/7eedfb46/attachment.html>