Power Manager cleanup

Kacper cosiekvfj at o2.pl
Thu Apr 4 16:43:15 CEST 2019


Hello.

> Could you please drop me the link to your github fork again ? (I 
> somehow lost the last mail :-[ )
https://github.com/vfjpl/xfce4-power-manager

> The functional commits probably will be applied.
> For the formatting/renaming-only commits I dont know. Think you have 
> to convince ochosi in #xfce-dev on irc for that.
Why is that? If there are some special request about style, I'm happy to 
do them manually.:-)
Currently there are many places where brackets are not aligned, there 
are no enough spaces etc.
> You are planning to provide more patches for xfce4-power-manager ?

My main issue is with xfce4-power-manager-settings. There is a bug where 
if you don't have setting in xfconf, xfpm-settings don't know what 
settings are in xfpm. xfpm have it's own internal storage. I was 
thinking about exposing this settings from xfpm by dbus. And then 
reading them in xfpm-settings. We already do that to some of the 
settings. So it would just be extending current model.


And my second issue. My laptop controls brightness itself. When xfpm is 
in control of brightness keys it disables firmware driver. If we set 
xfpm to not control keys then it enables firmware driver. So right now I 
have:

Laptop - firmware driver
or
Laptop - xfpm

I thought about adding switch to disable firmware driver manually. That 
way I can disable both xfpm and firmare driver and let my laptop control 
the brightness. And I still would have popup brightness indicator and 
control from tray icon.

Cheers,
Kacper




More information about the Xfce4-dev mailing list