[Thunar] Gtk3 porting - preparation step

Fri Mar 10 09:31:42 CET 2017

Hello.

I'm sending patches as attachments - separated as mentioned before for
easy reviewing, also including cumulative one.

This work (surely not entertaining) solves this one thing
 $ make CFLAGS+="-DGSEAL_ENABLE"

This is all current and can be a base for further gtk3 porting.

Greets

--
vlado

On Ut, 2017-03-07 at 22:53 -0300, André Miranda wrote:
> Hi Vladmir,
> Every help in the porting effort is more than welcome!
> Currently there is unmaintained work[1][2], you can setup a personal
> repository on GitHub and use them as a start point.
> Many components and panel plugins have been ported, they are also
> good references.
> However I suggest you talk with devs on #xfce-dev so they can give
> you better hints than me.
> 
> 1 - https://wiki.xfce.org/releng/4.14/roadmap/thunar
> 2 - https://github.com/rgcjonas/thunar-gtk3
> 
> Cheers,
> André Miranda
> 
> On Mon, Mar 6, 2017 at 4:54 AM, Vladimír Chren <vlado.chren at inmail.sk
> > wrote:
> > Hello All.
> > 
> > I don't know details about Thunar gtk3 porting status but it looks
> > that
> > there is no big progress.
> > 
> > Would you be interested in patches solving one preparation step of
> > porting Thunar to gtk3 according to manual
> >  https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to-3.html#
> > id-1
> > .6.3.3.5
> > 
> > Chapter "Use accessor functions instead of direct access"
> > 
> > Patches would look mostly like this
> >  -  GTK_BIN (standard_view)->child
> >  +  gtk_bin_get_child (GTK_BIN (standard_view))
> > 
> > and like this
> >  - renderer->is_expanded
> >  + g_object_get (renderer, "is-expanded", &is_expanded, NULL);
> > 
> > I'll separate each type of change to different patch.
> > 
> > This could be then applied against master (i think) because it's
> > still
> > gtk2 (2.24.0) and nothing changes functionally. I'll reuse what was
> > already done and update it to current master.
> > 
> > Patches would be longer but simple to review.
> > 
> > I'm asking first if it's necessary or useful to do it.
> > 
> > 
> > Thank you
> > 
> > --
> > vlado
> > 
> > 
> > _______________________________________________
> > Xfce4-dev mailing list
> > Xfce4-dev at xfce.org
> > https://mail.xfce.org/mailman/listinfo/xfce4-dev
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cumulative-gtk3-porting-Use-accessor-functions-instead-of-direc.patch
Type: text/x-patch
Size: 92970 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gtk3-porting-Use-gtk_bin_get_child.patch
Type: text/x-patch
Size: 24109 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-gtk3-porting-Use-gtk_dialog_get_content_area.patch
Type: text/x-patch
Size: 12395 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-gtk3-porting-Use-gtk_dialog_get_action_area.patch
Type: text/x-patch
Size: 1419 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0021.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-gtk3-porting-Use-gtk_container_get_border_width.patch
Type: text/x-patch
Size: 4553 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0022.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-gtk3-porting-Use-gtk_widget_get_style.patch
Type: text/x-patch
Size: 8999 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0023.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-gtk3-porting-Use-gtk_widget_get_parent.patch
Type: text/x-patch
Size: 2553 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0024.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-gtk3-porting-Use-gtk_widget_set_allocation.patch
Type: text/x-patch
Size: 1635 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0025.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-gtk3-porting-Use-gtk_widget_get_window.patch
Type: text/x-patch
Size: 6178 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0026.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-gtk3-porting-Use-gtk_selection_data_get_.patch
Type: text/x-patch
Size: 9463 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0027.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-gtk3-porting-Use-gdk_drag_context_get_.patch
Type: text/x-patch
Size: 8118 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0028.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-gtk3-porting-Access-properties-of-GtkCellRenderer-co.patch
Type: text/x-patch
Size: 11975 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0029.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-gtk3-porting-Use-gtk_widget_get_requisition-and-gtk_.patch
Type: text/x-patch
Size: 9026 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0030.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-gtk3-porting-Use-gtk_entry_get_.patch
Type: text/x-patch
Size: 4001 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0031.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-gtk3-porting-Use-gdk_drag_context_get_source_window.patch
Type: text/x-patch
Size: 2676 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0032.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-gtk3-porting-Use-gtk_adjustment_get_.patch
Type: text/x-patch
Size: 3071 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0033.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-gtk3-porting-Use-gtk_container_get_children.patch
Type: text/x-patch
Size: 2216 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0034.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-gtk3-porting-Use-gtk_widget_get_realized.patch
Type: text/x-patch
Size: 1111 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170310/0810c006/attachment-0035.bin>