Porting xfdesktop to Gtk3

[André Miranda]

Hi again Florian,
Your work is getting much more polished, just a few rough edges I could 
find (some I mentioned before, I hope to be more clear now):
- Sometimes when a window is focused, the Trash tooltip doesn't appear
- Help confirmation message is too wide (see attachment)
- Desktop dialog content doesn't fill the window vertically (see attachment)
- Icon's label not themed correctly (see attachment, changing theme 
doesn't make any difference, the labels always have that ugly gray 
background and the selected icon is not colored).
- And the annoying selection rectangle =)

Thanks your work!

Cheers,
André Miranda

On 02/03/2017 10:06 PM, Florian Weigelt wrote:
> You can checkout my gtk3 branch from
> https://github.com/Flow-It/xfdesktop.git
> It only has the fixes mentioned with the last patch I sent. I've been
> working a bit on some other issues but they probably need bigger changes
> (xfconf backend for example).
>
> On 01/31/17 02:43, André Miranda wrote:
>> Hi Florian,
>> Sorry for the long delay... Unfortunately I couldn't apply the patch
>> against master, can you provide a repository on GitHub or elsewhere?
>> About the Dialog Settings, as far as I recall, if resized its contents
>> retain the same size, just the window grows and white/gray fills the new
>> space.
>> Looking forward a repository to test your fixes.
>>
>> Cheers,
>> André Miranda
>>
>> On 01/21/2017 07:39 PM, Florian Weigelt wrote:
>>> I managed to track down the issue with the desktop icons. I attach my
>>> current work as a new patch for some more testing.
>>> As already mentioned, I cannot test behaviour on multiple monitors.
>>> Hopefully those issues were related to the icons and are gone now as
>>> well, but that's up to you to find out.
>>>
>>> On 12/21/16 00:49, André Miranda wrote:
>>>> - Desktop Settings dialog's content are not resizing vertically
>>> Could you please describe what you mean exactly? The settings dialog
>>> looks fine to me.
>>>> - After dragging a file the selection rectangle appears
>>> Unfortunately, this issue still persists.
>>>> - "Show hidden files on desktop" make all the icons disappear (they
>>>> reappear if icon size is changed)
>>> Fixed!
>>>> - Icon context menus are not dismissed on first click out
>>> Fixed! But after the popup is hidden we get the selection rectangle,
>>> too, as in the issue above.
>>>> - Icons are not correctly themed (Numix here)
>>> Adwaita and elementary icons work fine.
>>>
>
>
>
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170205/f759d07a/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dialog.png
Type: image/png
Size: 181353 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170205/f759d07a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtk2_icons.png
Type: image/png
Size: 16774 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170205/f759d07a/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtk3_icons.png
Type: image/png
Size: 15523 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170205/f759d07a/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: help_message.png
Type: image/png
Size: 20055 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170205/f759d07a/attachment-0007.png>