[Patch] Add xfce_image_menu_item_new to libxfce4ui

[Simon Steinbeiss]

Hi Florian,

without having reviewed the patch (although if it's based on upstream
anyway, it should be fine) I agree we may want/need something like this.

So far the approach we've taken in other components was to wrap all
gtk_image_menu_items in ignore deprecation statements (e.g. xfpm). I
wouldn't mind using libxfce4ui instead, as it would result in cleaner code.

I don't think you have to worry much about Gtk2, it's not our goal to have
a cross-compatible desktop anyway, we don't even seem to have enough
manpower for one toolkit version alone...

Thanks for your efforts
Simon




Igor Zakharov <f2404 at yandex.ru> schrieb am Sa., 4. Feb. 2017, 09:01:

> Hi,
>
> The patch looks good to me, and I'd like to have it merged.
> Ristretto is also using GtkImageMenuItem, and this proposed functionality
> could be used in the gtk3 port.
>
> Igor
>
> 04.02.2017, 04:59, "Florian Weigelt" <weigelt.florian at gmx.net>:
>
> Please find attached a patch which adds some functionality to libxfce4ui
> to use a GtkMenuItem with an icon without using the (in gtk3) deprecated
> GtkImageMenuItem.
> The code is based on the example given here:
> https://developer.gnome.org/gtk3/stable/GtkImageMenuItem.html
>
> This function is not intended to be used for creating menu bars. Using
> GtkBuilder with GMenu (which actually has an icon property) is by far
> better suited for this purpose.
> However, applications like xfdesktop and xfce4-panel also use
> GtkImageMenuItem's and it would be nice to offer the same functionality
> in a gtk3 port of these applications.
>
> I decided on those three parameters because those were the three
> information usually available when I looked at xfdesktop's sources. It
> is also possible to let the user create a GtkLabel first and pass this
> widget to the function.
> It would also be possible to exclude this function entirely from the
> gtk2 build of libxfce4ui where GtkImageMenuItems weren't deprecated.
> Please share your thoughts on this.
>
> Kind regards
>
> ,
>
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev
>
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20170204/a1f31f0b/attachment.html>