[PATCH] Add support to lightdm lock screen tool

[flo.xfce at gmx-topmail.de]

There was a discussion about how to improve or not improve the xflock4
script in https://bugzilla.xfce.org/show_bug.cgi?id=10217. This may
answer a few questions. Also, instead of modifying xflock you can follow
the advice here: https://wiki.archlinux.org/index.php/Xfce#Lock_the_screen
Basically, I am not against adding more options to the xflock script but
it seems unnecessary. Locking in xorg is broken anyway and the
LockCommand entry in xfconf should be sufficient for all users. Distros
can ship a modified version of xflock anyway if they want to support a
specific lock tool.

On 09/23/16 18:33, Adam Glover wrote:
> FWIW, I use light-locker, and it has the same --lock option that
> gnome-screensaver-command uses.  If you work without gnome-screensaver
> installed, then you can do what I do, which is make a symlink to
> light-locker-command.  It avoids having to worry changing the script
> every time you update the package (assuming the use of distro packages).
> 
> I'm reading a bit on dm-tool (I hadn't noticed its existence before
> now), and it looks to me like it uses dbus to send commands to the
> session manager, which must be configured for a locker. This is
> generating security complaints for cases where the user doesn't have one
> installed or configured (technically the user/admin's fault). 
> Personally, I find it easier to just skip all that and work with the
> existing xflock script, which calls the commands directly (and I shim in
> the program I actually want to use like above).
> 
> 
> On 09/23/2016 09:08 AM, Sean Davis wrote:
>> By using hard-coded system paths, it reduces the risk of a malicious
>> application being installed at the user level (by script or other
>> method) and executed by xflock4.
>>
>> On Fri, Sep 23, 2016 at 7:40 AM Genghis Khan <genghiskhan at gmx.ca
>> <mailto:genghiskhan at gmx.ca>> wrote:
>>
>>     Question to the developers.
>>
>>     Why are the lock commands are hard-coded?
>>
>>     I would expect to use Desktop Files instead.
>>
>>     Potential directories:
>>     /usr/share/xflock4/
>>     /usr/share/xfce4/xflock4/
>>
>>     > Sent: Thursday, September 22, 2016 at 11:46 PM
>>     > From: "Alexander Alzate Olaya" <alexanderao at hospitec.com.co
>>     <mailto:alexanderao at hospitec.com.co>>
>>     > To: xfce4-dev at xfce.org <mailto:xfce4-dev at xfce.org>
>>     > Subject: [PATCH] Add support to lightdm lock screen tool
>>     >
>>     >
>>     _______________________________________________
>>     Xfce4-dev mailing list
>>     Xfce4-dev at xfce.org <mailto:Xfce4-dev at xfce.org>
>>     https://mail.xfce.org/mailman/listinfo/xfce4-dev
>>
>>
>>
>> _______________________________________________
>> Xfce4-dev mailing list
>> Xfce4-dev at xfce.org
>> https://mail.xfce.org/mailman/listinfo/xfce4-dev
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev