lightdash: Preferences window freezes after opening dashboard

[Matthew Brush]

On 15-09-04 01:28 PM, adlo wrote:
> Thanks for that, that's fixed it! [...]
>

FYI, you can trivially find problems like that by using stronger 
compiler warnings like `-Wall -Wextra -Werror`. That way it will almost 
never compile successfully if you have such bugs in your code.

Cheers,
Matthew Brush

>
>
>> On 4 Sep 2015, at 18:55, Jonas Kümmerlin <rgcjonas at gmail.com> wrote:
>>
>> lightdash_window_event doesn't return a value (i.e. returns void) where it
>> should return a GdkFilterReturn [1]. This WILL wreck havoc some way or another
>> and might well be responsible for the symptoms you're experiencing.
>>
>> [1] https://developer.gnome.org/gdk3/stable/gdk3-Windows.html#GdkFilterFunc
>>
>> Am Freitag, den 04.09.2015, 18:21 +0100 schrieb adlo:
>>> I am writing a panel plugin called lightdash, which aims to be a lightweight
>>> GNOME Shell-like dashboard for Xfce.
>>>
>>> After opening the dashboard, the preferences window freezes. I have narrowed
>>> it down to an issue with GDK event filters, as it works properly when I remove
>>> the call to gdk_window_add_filter () here:
>>>
>>> https://github.com/adlocode/xfce4-lightdash-plugin/blob/master/src/lightdash-w
>>> indow-switcher.c#L1301
>>>
>>> I am not sure how to resolve this issue; does anyone have any ideas?
>>>
>>> Regards
>>>
>>> adlo
>>>
>>>
>>> _______________________________________________
>>> Xfce4-dev mailing list
>>> Xfce4-dev at xfce.org
>>> https://mail.xfce.org/mailman/listinfo/xfce4-dev
>> _______________________________________________
>> Xfce4-dev mailing list
>> Xfce4-dev at xfce.org
>> https://mail.xfce.org/mailman/listinfo/xfce4-dev
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev
>