Window previews in xfwm4

[Stephan Haller]

Hi Olivier,

it works for me and well :) But the same suggestion Sonal got applies to
your implementation. Is it possible to add the application icon in front
of the application name? It would make it easier to recognize where the
window belongs to.

Awesome work - both :D

Now I just need a way to retrieve this image for use in xfdashboard ;) 

Greetings and thanks
Stephan


Am Samstag, den 24.01.2015, 22:53 +0100 schrieb Olivier Fourdan:
> Hi
> 
> Meanwhile I've pushed in git master the implementation I was trying to
> explain, it seems to work quite well.
> 
> Cheers,
> Olivier
> 
> 
> On 15 January 2015 at 19:46, Sonal Santan <sonal.santan at gmail.com> wrote:
> > I hope to look into it soon.
> >
> > -Sonal
> >
> >
> > On Wed, Jan 14, 2015 at 10:52 AM, Olivier Fourdan <fourdan at gmail.com> wrote:
> >>
> >> Sonal,
> >>
> >> The implementation I pointed out is actually much simpler than yours,
> >> and you get GdkPixbuf as well, I reckon it's much better and efficient
> >> than using XGetImage().
> >>
> >> Cheers
> >> Olivier
> >>
> >>
> >> On 13 January 2015 at 15:52, Olivier Fourdan <fourdan at gmail.com> wrote:
> >> > Nope, sorry.
> >> >
> >> > Olivier
> >> >
> >> > On 13 January 2015 at 15:08, Sonal Santan <sonal.santan at gmail.com>
> >> > wrote:
> >> >> Hello,
> >> >>
> >> >> IMHO this implementation fits very well with the existing
> >> >> infrastructure in
> >> >> tabwin which expects a GdkPixbuf to draw onto the window buttons,
> >> >> requiring
> >> >> minimal changes overall. I do agree that in an ideal world we would not
> >> >> use
> >> >> XGetImage to capture the contents of the preview pixmap but directly
> >> >> render
> >> >> the preview over a picture provided by the preview client. But that
> >> >> would
> >> >> require more changes. Also, I believe this implementation is inline
> >> >> with my
> >> >> original proposal of using XImage as a mechanism to exchange previews
> >> >> to
> >> >> clients. The images are small so the overhead should not be huge.
> >> >>
> >> >> Can we go ahead with the current design for now while I will look at
> >> >> optimizing the implementation as a future step?
> >> >>
> >> >> -Sonal
> >> >>
> >> >> On Mon, Jan 12, 2015 at 10:10 AM, Olivier Fourdan <fourdan at gmail.com>
> >> >> wrote:
> >> >>>
> >> >>> Hi
> >> >>>
> >> >>> I haven't looked much at the code, but using XGetImage and XImage
> >> >>> conversion seem inappropriate here.
> >> >>>
> >> >>> Using a compositor, all client windows are unredirected, meaning they
> >> >>> are rendered to an offscreen pixmap already, and the compositor has
> >> >>> all that's required already, it "knows" about all this so all you need
> >> >>> to do is to add hooks in the compositor to retrieve this and use that
> >> >>> picture, that's all. Metacity's compositor was based originally on
> >> >>> xfwm4's and had that feature up until not too long ago (not sure it's
> >> >>> still there), you should look there for an example.
> >> >>>
> >> >>> Also, please note that the gtk_ prefix is for gtk alone.
> >> >>>
> >> >>> Cheers,
> >> >>> Olivier
> >> >>
> >> >>
> >> >>
> >> >> _______________________________________________
> >> >> Xfce4-dev mailing list
> >> >> Xfce4-dev at xfce.org
> >> >> https://mail.xfce.org/mailman/listinfo/xfce4-dev
> >> _______________________________________________
> >> Xfce4-dev mailing list
> >> Xfce4-dev at xfce.org
> >> https://mail.xfce.org/mailman/listinfo/xfce4-dev
> >
> >
> >
> > _______________________________________________
> > Xfce4-dev mailing list
> > Xfce4-dev at xfce.org
> > https://mail.xfce.org/mailman/listinfo/xfce4-dev
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev