Some UX changes to Screenshooter

[Steve Dodier-Lazaro]

Hi,

I'll try and make time for a second run over Liviu's request, and the
proper implementation of the text overlay. For the 1 second delay, can I
then please make a config key to remove the "1 second" min delay on the
spinner, and then use a usleep (min(0.2, delay) * G_USEC_PER_SEC)? This way
I'd get my fast xfce4-screenshooter (and so would other power users) and
the general user base would stay safe. I'm also considering adding a tiny
"Settings" dialog for the filename request so that setting could be exposed
over there.

What do you think?


2014-04-30 21:08 GMT+01:00 Jérôme Guelfucci <jeromeg at xfce.org>:

> Hi,
>
> As the "current" but not active maintainer of xfce4-screenshooter,
> here follows my quick review:
>
> - those patches are very welcome!
> - don't use "//" comments, the existing code uses "/* */" comments
> - "Error dialog now supports markup, has nicer error message for when
> an…" could use being split in three (the three items in your
> description in fact).
> - "No longer waiting a whole second for a screenshot, but 200ms" I
> personally wouldn't accept this one. I spent hours trying to reduce
> this delay but it kept failing for someone. Since I increased the
> delay to 1s, we got 0 bug report about a crash and this delay is IMO
> no big deal.
> - "Notify the ability to cancel a region selection with Esc" I am not
> very found of this solution. Drawing text in the overlay window when
> composited or a kind of tooltip would be far better.
>
> Cheers,
>
> Jérôme
>
> On Wed, Apr 30, 2014 at 6:46 PM, Liviu Andronic <landronimirc at gmail.com>
> wrote:
> > Dear Steve,
> >
> > On Wed, Apr 30, 2014 at 1:58 AM, Steve Dodier-Lazaro
> > <sidnioulz at gmail.com> wrote:
> >> If you know of other (quick to write) UX improvements that are badly
> needed
> >> (and not in the bugzilla), please do tell me (except storing the Zimagez
> >> password in cleartext ;) ).
> >>
> > One issue that absolutely needs to be fixed prior to a new release is
> > the naming convention:
> > https://bugzilla.xfce.org/show_bug.cgi?id=8445
> > https://bugzilla.xfce.org/show_bug.cgi?id=10348
> >
> > It would be great if someone were to push a fix for this issue.
> >
> > Regards,
> > Liviu
> >
> >
> >> Thanks,
> >> --
> >> Steve Dodier-Lazaro
> >> PhD Student in Information Security
> >> University College London
> >> Free Software Developer
> >> OpenPGP : 1B6B1670
> >>
> >> _______________________________________________
> >> Xfce4-dev mailing list
> >> Xfce4-dev at xfce.org
> >> https://mail.xfce.org/mailman/listinfo/xfce4-dev
> >
> >
> >
> > --
> > Do you know how to read?
> > http://www.alienetworks.com/srtest.cfm
> > http://goodies.xfce.org/projects/applications/xfce4-dict#speed-reader
> > Do you know how to write?
> > http://garbl.home.comcast.net/~garbl/stylemanual/e.htm#e-mail
> > _______________________________________________
> > Xfce4-dev mailing list
> > Xfce4-dev at xfce.org
> > https://mail.xfce.org/mailman/listinfo/xfce4-dev
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev
>



-- 
Steve Dodier-Lazaro
PhD Student in Information Security
University College London
Free Software Developer
OpenPGP : 1B6B1670
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20140430/1bd13379/attachment.html>