Xfwm4 compositor zooming patch

Alistair Buxton a.j.buxton at gmail.com
Mon Nov 25 19:39:09 CET 2013

On 25 November 2013 09:03, Nick Schermer <nick at xfce.org> wrote:
> On Sat, Nov 16, 2013 at 5:56 PM, Alistair Buxton <a.j.buxton at gmail.com>
> wrote:
>> I've made a new branch with some fixes:
>> https://github.com/ali1234/xfwm4/commits/zoom2
>> I think this still needs more testing before being merged, as the one
>> person who reported it doesn't work got a completely black screen
>> which is a pretty bad regression.
> But the regression only occurs during zooming, so its not that bad. The
> problem with the branch is that not a lot of people will test it.

No, they reported regression happens all the time as soon as xfwm4
starts. This doesn't make much sense, but there you go. I agree nobody
will test it :(

>> Xfwm4 compositor already gets the refresh rate of the display using
>> randr. It is probably better to use that where available, rather than
>> a hardcoded value.
> Maybe the full refresh rate is a bit too much, half of it feels responsive
> enough here. Also to cut the calls to XQueryPointer.

Ok. There's actually a bug with this little bit of code: It's possible
to have RANDR but not LIBDRM, which causes the code to not compile.
It's just a matter of moving around some checks. I'll fix this and
make a new branch.

Alistair Buxton
a.j.buxton at gmail.com

More information about the Xfce4-dev mailing list