[Xfce4-commits] <xfce4-dev-tools:master> Don't set the default visibility in XDT_FEATURE_VISIBILITY.

Brian J. Tarricone brian at tarricone.org
Thu Oct 22 13:05:07 CEST 2009


Nick, revert this please.  If you don't want to use visibility properly
in your module, then don't use the macro.  Don't make it useless for
everyone else.

On 10/22/2009 02:22 AM, Nick Schermer wrote:
> Updating branch refs/heads/master
>          to 77d9703dccee853d007c3b7133bc14accff66203 (commit)
>        from 399b5f31fba3b76767041bdd0d7ad57c53ee1866 (commit)
> 
> commit 77d9703dccee853d007c3b7133bc14accff66203
> Author: Nick Schermer <nick at xfce.org>
> Date:   Thu Oct 22 11:18:06 2009 +0200
> 
>     Don't set the default visibility in XDT_FEATURE_VISIBILITY.
>     
>     Only use XDT_FEATURE_VISIBILITY to detect if visibility is
>     supported by the compiler. Setting the default visibility
>     to hidden will break libraries and modules that don't
>     set the visibility of their public function to "default".
> 
>  m4macros/xdt-features.m4 |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/m4macros/xdt-features.m4 b/m4macros/xdt-features.m4
> index ea0c685..be355b6 100644
> --- a/m4macros/xdt-features.m4
> +++ b/m4macros/xdt-features.m4
> @@ -164,8 +164,6 @@ AC_DEFUN([XDT_FEATURE_VISIBILITY],
>  
>    if test "x$have_gnuc_visibility" = "xyes"; then
>      CPPFLAGS="$CPPFLAGS -DHAVE_GNUC_VISIBILITY"
> -    XDT_SUPPORTED_FLAGS([xdt_vis_hidden_cflags], [-fvisibility=hidden])
> -    CFLAGS="$CFLAGS $xdt_vis_hidden_cflags"
>    fi
>  
>    AM_CONDITIONAL([HAVE_GNUC_VISIBILITY], [test "x$have_gnuc_visibility" = "xyes"])
> _______________________________________________
> Xfce4-commits mailing list
> Xfce4-commits at xfce.org
> http://foo-projects.org/mailman/listinfo/xfce4-commits



More information about the Xfce4-dev mailing list