XfceSMClient is done-ish

[Mike Massonnet]

2009/10/5 Brian J. Tarricone <brian at tarricone.org>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/05/2009 08:03 AM, Nick Schermer wrote:
>> 2009/10/5 Brian J. Tarricone <brian at tarricone.org>:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Hi guys,
>>>
>>> I think I'm pretty happy with the XfceSMClient API, and I'm more or less
>>> ready to merge it back to master.  Please let me know if you have
>>> comments or suggestions.
>>
>> Some random comments:
>>
>> - A guchar for the priority feels a bit weird. I userstand you do this
>> for the SmProp, but a guint is probably nicer for public api.
>
> I thought about this quite a bit, but I'd rather not (I think my
> original version used gint, but I later changed it).  The XSMP spec
> restricts the priority to values from 0 to 255.  A guint just makes that
> confusing -- at least, you'd have to read (and remember) the doc to know
> what the allowed values are.

The typedef guint8 can be used for that purpose and makes it clear it
is a numeric value.

>> - xfce_safe_strcmp -> g_strcmp0
>
> Gah, I *knew* there was a 'safe' function for that, but couldn't
> remember the name.

Hehe, I usually look for functions starting with g_ascii_, in that
case g_ascii_strcasecmp and its case sensitive version
g_ascii_strncasecmp.

Cheers
-- 
Mike