[Xfce4-commits] r30347 - in thunar/branches/migration-to-gio: . thunar

[Nick Schermer]

2009/7/21 Yves-Alexis Perez <corsac at debian.org>:
> On sam, 2009-07-18 at 17:28 +0000, Jannis Pohlmann wrote:
>> Author: jannis
>> Date: 2009-07-18 17:28:56 +0000 (Sat, 18 Jul 2009)
>> New Revision: 30347
>>
>> Modified:
>>    thunar/branches/migration-to-gio/ChangeLog
>>    thunar/branches/migration-to-gio/thunar/thunar-file.c
>> Log:
>>         * thunar/thunar-file.c: Only return true from
>>           thunar_file_is_executable() if the file is either a desktop file or
>>           is an application/x-executable or application/x-shellscript. On
>>           Windows we use g_content_type_can_be_executable() directly instead
>>           of checking for these two content types. Patch by Nick.
>
> About that, would it make sense to fix
> http://bugzilla.xfce.org/show_bug.cgi?id=5012 ?
>
> It seems that by default other environment don't execute .desktop files
> if they are not “global” (only writable by root) or if they are not
> marked as executable.
>
> What do you think?

Yeah makes sense. If both of the conditions are not true, we can show
a dialog explaining why the .desktop file is not launched.

Nick