[Xfce4-commits] r30225 - in xfce4-appfinder/trunk: . src

[Nick Schermer]

2009/7/9 Jannis Pohlmann <jannis at xfce.org>:
> -  if (G_UNLIKELY (!xfce_exec_on_screen (screen, command, FALSE, TRUE, &error)))
> +  if (G_UNLIKELY (!xfce_exec_on_screen (screen, command, FALSE, FALSE, &error)))

Agree with Brian here.

> +  if (G_LIKELY (categories != NULL))
> +    {
> +      categories_array = g_new0 (const gchar *, g_list_length (categories) + 1);
> +
> +      for (lp = categories, n = 0; lp != NULL; lp = lp->next, ++n)
> +        categories_array[n] = lp->data;
> +
> +      categories_string = g_strjoinv (", ", (gchar **) categories_array);
> +      g_string_append_printf (tooltip_str, _("<b>Categories:</b> %s\n"), categories_string);
> +      g_free (categories_string);
> +
> +      g_free (categories_array);
> +    }

This code is looks crap, it uses a wrong type, creates an extra array
only because it wants to use g_strjoinv?

Nick