Xfce 4.6 BETA-3 (Tuco-Tuco) Released

[Brian J. Tarricone]

Landry Breuil wrote:
> On Thu, Jan 15, 2009 at 8:37 PM, Brian J. Tarricone <bjt23 at cornell.edu> wrote:
>> Kok, Auke wrote:
>>> Brian J. Tarricone wrote:
>>>> Oliver Lehmann wrote:
>>>>
>>>>> +#ifndef environ
>>>>> +extern char **environ;
>>>>> +#endif
>>>>
>>>> Nuh-uh.  ifndef is almost certainly not what we want here.  Either use a
>>>> FreeBSD-specific check, or add a generic check to configure to see if it
>>>> needs to be declared or not.
>>> there should not be anything wrong with just adding an extern *without*
>>> the
>>> #ifdef....
>> Yeah, that's true.  A double-extern really isn't a big deal if it's declared
>> the same way in both places, and I wouldn't imagine environ to ever be
>> anything but a char**.  But I'd rather be safe.  You can do a test for it in
>> configure.ac in just a few lines.
> 
> Same error on OpenBSD, adding 'extern char** environ;' around the top of
> launcher-exec.c makes it compile fine. I'd take the official fix for 4.6.

Somebody should open bugs for this on bugzilla (if there aren't any 
there already) so this doesn't get lost...

	-brian