[PATCH] Added support for detecting removable media in ghal-0

[Michael Unterkalmsteiner]

> On 08/06/2009 02:26 AM, Michael Unterkalmsteiner wrote:
> > I'm playing with volstatus-icon and plan to implement mounting capability
> > (I like to mount devices manually when needed or re-mount an already
> > unmounted device... the icon would be perfect for that...)
>
> Sorry, won't be accepted.  There have been discussions about this
> before.  

Hm, sorry to hear that. Regarding discussions I found only this:
http://foo-projects.org/pipermail/xfce/2007-July/021559.html

> I'm of the opinion that mount/unmount are things users
> shouldn't have to deal with.  It's unfortunate enough that you have to
> "eject" media (well, unmount, minimally) to be safe before unplugging.

Agreed. 
But I think for people who use automount the additional feature wouldn't hurt. 
For users without automount, it would improve the way to (re-)mount media 
(without going to the cmd-line, desktop icon, etc.). 

> Adding mount/unmount options will only add clutter.
Depends how it is implemented in the context menu (if you mean by "clutter" 
the UI experience)... I thought of something like this (just an example):

[Icon A] Safely remove Device 1
[Icon A] Safely remove Device 2
[Separator]
[Icon B] Mount Device 3  --> would mount all volumes on device 3, otherwise 
there's a miss-match with the Volume / Device metaphor, i.e. it doesn't make 
sense to mount volumes individually and then to remove them together as a 
device.

After mounting device 3, the context-menu would look like this:

[Icon A] Safely remove Device 1
[Icon A] Safely remove Device 2
[Icon A] Safely remove Device 3

Additionally, if a medium is mounted, the volstatus icon should have a red 
circle (like a stop sign) somewhere on its edges to notify the user that 
something is still not safe to unplug. 
The volstatus icon alone would not be indication enough anymore, since it 
would be visible even if all devices are unmounted but still attached (this is 
the reason why I needed the support for detecting if a medium is inserted in a 
device, i.e. to handle the case when a CD is removed from the drive then the 
icon should become invisible). 

>
> If you need that sort of ability, xfce4-volstatus just probably isn't
> going to be right for you.
Right, as it is now, no...

M

>
> 	-brian