[Xfce4-commits] r27912 - xfdesktop/trunk/modules/menu

Jannis Pohlmann jannis at xfce.org
Sat Sep 20 12:32:13 CEST 2008

Am Sat, 20 Sep 2008 05:43:26 +0000 (UTC)
schrieb "Brian Tarricone" <kelnos at xfce.org>:

> Author: kelnos
> Date: 2008-09-20 05:43:26 +0000 (Sat, 20 Sep 2008)
> New Revision: 27912
> Modified:
>    xfdesktop/trunk/modules/menu/desktop-menu.c
> Log:
> fix menu module crash on .desktop file change or icon theme change
> (bug 3615)
> this also fixes the weird "double menu" problem (bug 4342).  what was
> happening was that thunar-vfs was firing off a dir change
> notification, and then the menu would start to regenerate.  then it
> would call into GtkIconTheme, which then noticed that the icon cache
> was stale and needed to be re-read.  so then it would fire
> GtkIconTheme::changed, which causes a recursive menu regeneration.
> since the menu generation function isn't reentrant, now we use
> g_idle_add() to schedule a menu regen, and we don't schedule one if
> there's one already scheduled or in progress.

Awesome! You just fixed our number one bug. I tested it and it seems to
work fine. No crashes, warnings or whatsoever. 

  - Jannis

More information about the Xfce4-dev mailing list