[Xfce4-commits] r28132 - in libexo/trunk: . exo-helper/helpers

[Christian Dywan]

Am Fri, 10 Oct 2008 13:12:56 -0700
schrieb "Brian J. Tarricone" <bjt23 at cornell.edu>:

> Jannis Pohlmann wrote:
> 
> > Log:
> > 	* exo-helper/helpers/Makefile.am,
> > 	  exo-helper/helpers/midori.desktop.in.in: Add Midori
> > helper. Patch provided by Christian Dywan. This closes bug #4446.
> [...]
> > +X-XFCE-CommandsWithParameter=%B "%s";
> 
> Is this correct?  I'd think any implementation (currently only
> exo-open) is broken if it doesn't properly quote shell arguments on
> its own.  (And if it uses an exec() that passes an argv and not a
> commandline, adding the quotes might break it.)

That's the same as in other helpers, ie. Galeon, Konqueror, Epiphany,
and friends. I did not actually try different strings, that one works
for me. - Surely that doesn't strictly mean it must be right :)

ciao,
    Christian