build errors libxfcegui4-4.5.91

[Ori Bernstein]

On Tue, 4 Nov 2008 16:14:50 -0700
Myles Green <rmg57 at telus.net> wrote:

> -o .libs/libxfcegui4_la-dialogs.o cc1: warnings being treated as errors
> dialogs.c: In function ‘message_dialog’: dialogs.c:278: error: format
> not a string literal and no format arguments dialogs.c: In function
> ‘xfce_confirm’: dialogs.c:447: error: format not a string literal and
> no format arguments make[3]: *** [libxfcegui4_la-dialogs.lo] Error 1

That's the actual error.
 
> There's probably something I'm not aware of that's causing this...
> Ubuntu 8.10, up to date. Can anyone point me in there right direction
> please?

It's compiler flags. Turn off -Werror, and things will build just fine.

And for security/crashproofing, perhaps it would be a good idea for
libxfce4gui to make sure that dialogs use string literals for format
strings, although it's not that big a deal.

-- 
    Ori Bernstein