libxfce4utils to patch: strip trailing slashes from resources paths

Jannis Pohlmann jannis at xfce.org
Sun Jun 29 15:56:02 CEST 2008


Hey guys,

I noticed that the new xfce4-settings-manager accidently lists all
settings dialogs twice. This is because I happen to have both
'/usr/share' and '/usr/share/' in XDG_DATA_DIRS. No idea why, but that
doesn't really matter.

I investigated this issue and found two things I'd like to improve:

  1. Use g_build_path instead of "%s/%s" in xfce-resource.c
     (libxfce4util) and xfce-settings-manager-dialog.c
     (xfce4-settings-manager).
  2. Remove trailing slashes from resource paths before duplicates are
     removed in _res_init() (in libxfce4util).

We already remove duplicate resource paths in _res_init() but IMHO not
consequently enough (e.g. '/usr/share' and '/usr/share/' are currently
not identified as duplicates). Attached is a patch which fixes the two
points mentioned above.

I'd like to commit this. Thoughts?

  - Jannis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libxfce4util-trailing-slashes.patch
Type: text/x-patch
Size: 4825 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20080629/ebfed885/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20080629/ebfed885/attachment.pgp>


More information about the Xfce4-dev mailing list