[Goodies-commits] r3809 - in ristretto/trunk: . src

[mmassonnet at gmail.com]

On Tue, Jan 15, 2008 at 09:55:10AM +0100, Stephan Arts wrote:
> On Jan 15, 2008 9:20 AM, Benedikt Meurer
> <meurer at informatik.uni-siegen.de> wrote:
> > Stephan Arts wrote:
> > > Author: stephan
> > > Date: 2008-01-14 22:14:51 +0000 (Mon, 14 Jan 2008)
> > > New Revision: 3809
> > >
> > > Modified:
> > >    ristretto/trunk/configure.in.in
> > >    ristretto/trunk/src/Makefile.am
> > >    ristretto/trunk/src/main.c
> > >    ristretto/trunk/src/navigator.c
> > >    ristretto/trunk/src/navigator.h
> > > Log:
> > > Remove xfcerc dep
> > >
> > >
> > > Modified: ristretto/trunk/configure.in.in
> > > ===================================================================
> > > --- ristretto/trunk/configure.in.in   2008-01-13 16:37:44 UTC (rev 3808)
> > > +++ ristretto/trunk/configure.in.in   2008-01-14 22:14:51 UTC (rev 3809)
> > > @@ -57,7 +57,6 @@
> > >  XDT_CHECK_PACKAGE([GOBJECT], [gobject-2.0], [2.12.0])
> > >  XDT_CHECK_PACKAGE([THUNAR_VFS], [thunar-vfs-1], [0.4.0])
> > >  XDT_CHECK_PACKAGE([DBUS_GLIB], [dbus-glib-1], [0.34])
> > > -XDT_CHECK_PACKAGE([LIBXFCE4UTIL], [libxfce4util-1.0], [4.4.0])
> > >  XDT_CHECK_PACKAGE([LIBXFCEGUI4], [libxfcegui4-1.0], [4.4.0])
> >
> > Err, you know that both libxfcegui4 and thunar-vfs pull in the
> > libxfce4util dependency? So you didn't save anything besides a DT_NEEDED
> > entry for libxfce4util, which is several times smaller than the overhead
> > in code size caused by this change.
> 
> 
> Ok, so in that case reverting this change would be better... thanks
> for the hint.

Yeah, good hint indeed.  I know I shouldn't because you will waste your
time, but here is another hint: http://www.bindaree.com.au/images/hint8.gif

Stephan, maybe this gives you some syntax idea for xfce_rc_read:
http://git.m8t.mine.nu/cgi-bin/gitweb.cgi?p=clipman.git;a=blob;f=panel-plugin/clipman.c;h=8981ce3928bec1e49fbd2a7653a4085743009a93;hb=HEAD
I find it easily readable, same for xfce_rc_write.

> Stephan

my 2 cents anyway :)
mike