Clock panel plugin crashes when newly added

[Enrico Tröger]

On Sun, 17 Feb 2008 21:33:57 +0100, "Nick Schermer"
<nickschermer at gmail.com> wrote:

> > I attached a backtrace of the crash. But I'm not yet sure why it
> > happens.
> > As you can see in the backtrace, it crashes in clock.c:128 because
> > format is NULL. But why doesn't work g_return_val_if_fail() before?
> > Shouldn't it return from the function?
> 
> You've probably disabled the debug macros (--enable-debug=no). Problem
Nearly, I use --disable-debug.
I didn't know the g_return_* macros doesn't work if G_DISABLE_CHECKS
is set. And I didn't know that G_DISABLE_CHECKS is set when using
--disable-debug. 

> is fixed in trunk.
and we get the next problem, see attached backtrace.
Seems to be the same problem at another position.
Attached patch does the same as your previous patch and fixes the new
crash.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xfce4_panel_clock_plugin_backtrace2
Type: application/octet-stream
Size: 3374 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20080217/7c6633f0/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xfce4_panel_clock_plugin_disable_debug.patch
Type: text/x-diff
Size: 616 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20080217/7c6633f0/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20080217/7c6633f0/attachment.pgp>