libxfce4panel could position panel plugin menus
jasper at xfce.org
Fri Sep 28 13:52:17 CEST 2007
2007/9/28, Diego Ongaro <ongardie at gmail.com>:
> On 9/25/07, Diego Ongaro <ongardie at gmail.com> wrote:
> > On 9/25/07, Jasper Huijsmans <jasper at xfce.org> wrote:
> > > 2007/9/24, Diego Ongaro <ongardie at gmail.com>:
> > > > I was able to fairly easily create a wrapper around gtk_menu_popup()
> > > > and get the launcher and window list plugins to use that.
> > > >
> > > > [snip]
> > > >
> > > > (2) Let libxfce4panel *guess* which way the menu will open based on
> > > > the panel's position on the screen. It'll always get it right for
> > > > fixed position panels, and it'll get it right most of the time for
> > > > floating panels (it might miss those that float near, but not at, the
> > > > bottom or right of the screen). Then, when it opens a menu, it will
> > > > report the actual direction the menu opened, and the plugin can adjust
> > > > the arrow's direction accordingly. This "cache" could even be saved in
> > > > the rc file.
> > >
> > > This sounds perfectly acceptable to me. Not many downsides and it
> > > works correctly in most use cases.
> > >
> Ok, so I implemented (2) above (minus the cache concept, as that
> seemed unnecessary). I also fulfilled Alexandre's request.
> Patches to libxfce4panel, the launcher plugin, and the windowlist
> plugin are attached to bug #3576.
Excellent! I have just committed the patches (rev. 26115) with only
I used the monitor geometry to make it more suitable for use with
Xinerama, I added button and event time arguments to
xfce_panel_plugin_menu_popup() to allow passing these on to
gtk_menu_popup() and a made few very small cosmetic changes.
Thanks a lot for making those patches! Now let's wait for the reports
of broken panel behavior ;-)
More information about the Xfce4-dev