[Xfce4-commits] r25278 - libxfcegui4/trunk/libxfcegui4

[Brian J. Tarricone]

Danny.... please stop breaking libgui ABI/API.  You can't just remove
functions from our public libraries without talking about it on the
ML.  How many times is this now?

	-brian

On Sat, 24 Mar 2007 19:47:32 +0000 (UTC), Danny Milosavljevic wrote:

> Author: dannym
> Date: 2007-03-24 19:47:32 +0000 (Sat, 24 Mar 2007)
> New Revision: 25278
> 
> Modified:
>    libxfcegui4/trunk/libxfcegui4/session-client.c
>    libxfcegui4/trunk/libxfcegui4/session-client.h
> Log:
> remove client_session_copy: doesn't work since the lowlevel session
> is not copied and I don't see a practical use either
> 
> 
> 
> Modified: libxfcegui4/trunk/libxfcegui4/session-client.c
> ===================================================================
> --- libxfcegui4/trunk/libxfcegui4/session-client.c	2007-03-24
> 17:10:17 UTC (rev 25277) +++
> libxfcegui4/trunk/libxfcegui4/session-client.c	2007-03-24
> 19:47:32 UTC (rev 25278) @@ -863,12 +863,16 @@ }
>  }
>  
> -gchar** safe_strvdup(gchar** const source)
> +gchar** safe_strvdup(const gchar * const * source)
>  {
>      int     count;
>      int     i;
>      gchar** result;
>      
> +    if (source == NULL) {
> +        return NULL;
> +    }
> +    
>      count = g_strv_length(source);
>      result = g_new0(gchar*, count + 1);
>      
> @@ -880,36 +884,6 @@
>      return result;
>  }
>  
> -/* messes with session_connection:
> -SessionClient *client_session_copy(SessionClient * session_client)
> -{
> -    SessionClient* result;
> -    result = g_new0(SessionClient, 1);
> -
> -    result->data = session_client->data;
> -    result->session_connection = session_client->session_connection; 
> -
> -    result->current_state = session_client->current_state;
> -    result->restart_style = session_client->restart_style;
> -    result->interact_style = session_client->interact_style;
> -
> -    result->priority = session_client->priority;
> -
> -    result->client_id = safe_strdup(session_client->client_id);
> -    result->given_client_id =
> safe_strdup(session_client->given_client_id); -
> -    result->current_directory =
> safe_strdup(session_client->current_directory);
> -    result->program = safe_strdup(session_client->program);
> -    result->clone_command =
> safe_strvdup(session_client->clone_command);
> -    result->resign_command =
> safe_strvdup(session_client->resign_command);
> -    result->restart_command =
> safe_strvdup(session_client->restart_command);
> -    result->discard_command =
> safe_strvdup(session_client->discard_command);
> -    result->shutdown_command =
> safe_strvdup(session_client->shutdown_command); -
> -    result->shutdown = session_client->shutdown;
> -}
> -*/
> -
>  void client_session_set_save_phase_2_callback(SessionClient *
> session_client, save_phase_2_callback value) {
>      session_client->save_phase_2 = value;
> 
> Modified: libxfcegui4/trunk/libxfcegui4/session-client.h
> ===================================================================
> --- libxfcegui4/trunk/libxfcegui4/session-client.h	2007-03-24
> 17:10:17 UTC (rev 25277) +++
> libxfcegui4/trunk/libxfcegui4/session-client.h	2007-03-24
> 19:47:32 UTC (rev 25278) @@ -119,7 +119,6 @@ gchar priority);
>  
>  void client_session_free(SessionClient * session_client);
> -/* SessionClient *client_session_copy(SessionClient *
> session_client); */ 
>  gboolean session_init (SessionClient * session_client);
>  void session_shutdown (SessionClient * session_client);
> 
> _______________________________________________
> Xfce4-commits mailing list
> Xfce4-commits at xfce.org
> http://foo-projects.org/mailman/listinfo/xfce4-commits
>