[Xfce4-commits] r24258 - in xfce4-panel/trunk: . libxfce4panel panel

[Jasper Huijsmans]

2007/1/4, Brian J. Tarricone <bjt23 at cornell.edu>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: RIPEMD160
>
> Jasper Huijsmans wrote:
> > Nick Schermer wrote:
> >> So do I re-reverty this patch? Maybe someone with the svn version of
> >> glib can try if this warning is printed when opening the command
> >> dialog from the launcher.
> >>
> >>
> >
> > Pfft, I don't know. Maybe wait a little for more discussion?
> >
> > This is a nice one too:
> > http://mail.gnome.org/archives/gtk-devel-list/2007-January/msg00036.html
> > .  At least we used to set the locale all over the place, and I don't
> > think this has been changed. The message seems to indicate this might
> > not work well when threads are being used.
>
> Do we really?  I know we call xfce_textdomain() in a bunch of places,
> but that doesn't call setlocale().  bindtextomain() etc. should be safe,
> I think, esp if called from only one thread.

Ah, yes, you are right. That is what I was thinking about. So, at
least we should be safe here.

-- 
        Jasper