[Xfce4-commits] r24827 - libxfcegui4/branches/xfce_4_4/libxfcegui4

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Danny Milosavljevic wrote:
> Author: dannym
> Date: 2007-02-03 14:19:40 +0000 (Sat, 03 Feb 2007)
> New Revision: 24827
> 
> Modified:
>    libxfcegui4/branches/xfce_4_4/libxfcegui4/netk-window.c
>    libxfcegui4/branches/xfce_4_4/libxfcegui4/netk-xutils.c
>    libxfcegui4/branches/xfce_4_4/libxfcegui4/netk-xutils.h
> Log:
> add netk_window_get_icon_geometry

Uh, Danny, why are you adding API to the 4.4 branch?  Please don't.  If
there's a valid reason for this, you should be discussing it on the ML,
or at the very least providing a rationale in your commit message.

Ditto for the IMHO useless convenience functions you've added to
NetkTrayIcon.  There's no reason to clutter the exports table with
one-line functions.

Why mess with NetkTasklist?  It's old and crusty and will be rewritten
sometime in the 4.5 cycle.

At any rate, NONE of this stuff should be added to the 4.4 branch.

	-brian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.1 (GNU/Linux)

iD8DBQFFxXVb6XyW6VEeAnsRA5qSAJ4kWnpovJe8eEZjd3udRfM2G7pmMgCdG7Aq
qQaj3GmpDwDA3D5mh1IZ2Bo=
=/I4G
-----END PGP SIGNATURE-----