[Xfce4-commits] r26505 - in xfdesktop/trunk: . modules/menu

[Brian J. Tarricone]

On Thu, 27 Dec 2007 02:15:01 +0100 Jannis Pohlmann wrote:

> Oops, my bad:
> 
>  * libxfce4menu/xfce-menu-monitor.c: Use the KEY, not the VALUE
>    pointer to remove items from the shared handle hash table. In this
>    case, use the directory string instead of the shared handle. This
>    should fix the issue we've had with monitoring directories only.
> 
> Mind to try again? Works fine now over here with both, xfdesktop and
> menu-test.c.

Nice, works here too... except...  it's constantly thinking something's
changed and it needs to be refreshed because
of /usr/local/share/applications, which doesn't exist on my box.
Apparently when you try to monitor a nonexistant directory, thunar-vfs
immediate fires the callback with a DELETED event.  Benny, is this
expected?

I guess the workaround here is to check for directory existence in my
'add directory' function, and not add a monitor if it doesn't exist.

Jannis, also one thing I realised.  It's really wasteful with
thunar-vfs to specify an 'add file' function since the directory
monitor will monitor all subfiles.  This you already know.  However,
without the 'add file' function, the .menu file itself doesn't get
watched, which is a problem.

Any ideas about this?  I'm thinking maybe I can specify an 'add file'
function, but somehow tell XfceMenu (with some kind of flag or extra
api) not to watch the .desktop files themselves.  But... I dunno.

	-brian