libxfce4ui

[Nick Schermer]

2007/12/17, Brian J. Tarricone <bjt23 at cornell.edu>:
> Nick Schermer wrote:
> > 2007/12/17, Brian J. Tarricone <bjt23 at cornell.edu>:
> >> Is it really necessary to have an extra widget for that?  If
> >> xfce_create_framebox() is doing much more than that, it shouldn't be.
> >
> > The new widget does the same, but is has a creaner api IMHO.
>
> The new widget is kinda just bloat, though, isn't it?  Why create an
> entirely new widget subclass to replace a convenience function that's
> less than 10 lines long?

http://foo-projects.org/~nick/tmp/xfce-frame.c
http://foo-projects.org/~nick/tmp/xfce-frame.h

So yes it's longer then 10 lines, but that's not really the point.
Personally I like the idea it works like a normal widget, and I always
found xfce_create_framebox weird from the api point of view,
xfce_create_framebox_with_content is a bit better tho.

So whether the code is 10 or 100 lines, nobody cares when it's
compiled, at least you won't notice it. So I though XfceFrame was a
nice solution, mostly because you use it like any other widget, but if
(like Benny said) this can be a problem with themes, well it's easy
and we drop it.

Nick