Segfault & patch for libxfcegui4

[Enrico Tröger]

On Tue, 21 Aug 2007 17:07:24 -0700, "Brian J. Tarricone"
<bjt23 at cornell.edu> wrote:

> Jean-François Wauthy wrote:
> > Le mardi 21 août 2007 à 20:54 +0200, Enrico Tröger a écrit :
> > 
> >> Yes, probably. I don't care how but it should be fixed.
> >>
> > 
> > I made the test more explicit in both the xfce_4_4 branch and trunk
> > (rev 25996).
> 
> Please don't make changes that have nothing to do with the problem. 
> There's no need; the code in question is correct.
Are you sure? I'm not sure about the g_return_val_if_fail but "*name"
always segfaults when name is NULL.
g_return_val_if_fail(name != NULL, NULL)
also doesn't seem to work. Why don't you just add the NULL check to the
if statement? g_strdup on NULL will just return NULL which should be
the desired result.

> No idea what's causing the crash - seems like the original backtrace 
> isn't valid.  ENrico, please just file a bug on bugzilla (the
> 'general' component is fine), and include the *full* backtrace.
Done. http://bugzilla.xfce.org/show_bug.cgi?id=3486

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20070822/6993e5b4/attachment.pgp>