Segfault & patch for libxfcegui4

Jasper Huijsmans jasper at xfce.org
Wed Aug 22 11:56:32 CEST 2007


2007/8/22, Brian J. Tarricone <bjt23 at cornell.edu>:
> Jean-François Wauthy wrote:
> > Le mardi 21 août 2007 à 20:54 +0200, Enrico Tröger a écrit :
> >
> >> Yes, probably. I don't care how but it should be fixed.
> >>
> >
> > I made the test more explicit in both the xfce_4_4 branch and trunk (rev
> > 25996).
>
> Please don't make changes that have nothing to do with the problem.
> There's no need; the code in question is correct.
>
> No idea what's causing the crash - seems like the original backtrace
> isn't valid.  ENrico, please just file a bug on bugzilla (the 'general'
> component is fine), and include the *full* backtrace.
>
>         -brian

If you want an explicit check, I don't think you can rely on g_return_if_fail.

I'm not sure if this is correct, but I thought g_return_* macros
should only really be used for debugging purposes, because they may be
defined as no-ops in certain configurations.

-- 
        Jasper


More information about the Xfce4-dev mailing list