Segfault & patch for libxfcegui4

Enrico Tröger enrico.troeger at uvena.de
Tue Aug 21 20:54:56 CEST 2007


On Tue, 21 Aug 2007 18:51:06 +0200, Jean-François Wauthy
<pollux at xfce.org> wrote:

> Le mardi 21 août 2007 à 15:05 +0200, Enrico Tröger a écrit :
> > Hi,
> > 
> hi
> 
> > In libxfcegui4/libxfcegui4/icons.c:218 is a small mistake which may
> > cause a segfault (like it happened here right now). Before checking
> > for "*name", name itself should be checked to be not NULL.
> 
> The NULL check is already there in g_return_val_if_fail(name, NULL);
Oops. I should read the code more carefully ;-).

> but somehow fails here (i guess the expression to check should be more
> explicit like name != NULL).
Yes, probably. I don't care how but it should be fixed.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20070821/2d6fd4e1/attachment.pgp>


More information about the Xfce4-dev mailing list