[Xfce4-commits] r25556 - libxfcegui4/branches/xfce_4_2/libxfcegui4

[Olivier Fourdan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jean-François Wauthy wrote:
> Le samedi 14 avril 2007 à 19:50 +0000, Olivier Fourdan a écrit :
>> -    session_client->client_id = client_id;
>> +    session_client->client_id = g_strdup (client_id);
> 
>> -	session_client->program = program;
>> +	session_client->program = g_strdup (program);
> 
>> -	session_client->current_directory = current_directory;
>> +	session_client->current_directory = g_strdup (current_directory);
> 
> I don't know the code well but didn't you forget to free these new
> strings ?

yes, I know, the strings are leaked, but it doesn't matter because only
one session is used per application and it's freed when the app
terminates anyway.

Cheers,
Olivier.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFGITiFFHBtvh5LRUARAuTiAJ4xst9QAvRcW+iT5aPCf9png01cUgCfUKWq
ifa0Zg0w16RfGlI6c7d67Hs=
=Z0oG
-----END PGP SIGNATURE-----