Xfce4-panel crashes on startup (trunk)

[Daichi Kawahata]

Hi Jasper,

On Wed, 11 Apr 2007 21:08:24 +0200
Jasper Huijsmans wrote:

(snip)

> Do you also have the latest libraries? I don't think that is the reason,
> but you never know. To me it looks like it may be memory corruption. I
> wonder why it calls save_yourself on startup...
>
> Maybe you could add the backtrace to bugzilla; it does look like a real
> bug to me.
>
> I'm afraid I don't really know where to start looking for the cause of
> this problem.

This patch fixes my problem, please check it.

Regards,
--
Daichi

ISO 639-2: http://www.loc.gov/standards/iso639-2/php/code_list.php
ISO 3166 : http://www.iso.org/iso/en/prods-services/iso3166ma/index.html
-------------- next part --------------
Index: libxfcegui4/trunk/libxfcegui4/session-client.c
===================================================================
--- libxfcegui4/trunk/libxfcegui4/session-client.c	(revision 25552)
+++ libxfcegui4/trunk/libxfcegui4/session-client.c	(working copy)
@@ -741,7 +741,7 @@
     session_client->interact_style = SESSION_INTERACT_NONE;
     session_client->session_connection = NULL;
     session_client->priority = priority;
-    session_client->client_id = client_id;
+    session_client->client_id = g_strdup(client_id);
     session_client->given_client_id = NULL;
     if (program)
     {
Index: xfce4-panel/trunk/panel/panel-app.c
===================================================================
--- xfce4-panel/trunk/panel/panel-app.c	(revision 25552)
+++ xfce4-panel/trunk/panel/panel-app.c	(working copy)
@@ -638,7 +638,7 @@
 #endif
     GIOChannel  *g_signal_in;
     GError      *error = NULL;
-    glong        fd_flags;
+    gint        fd_flags;
     gchar      **restart_command;
 
     /* create pipe and set writing end in non-blocking mode */
@@ -715,7 +715,7 @@
     xfce_setenv ("DISPLAY", gdk_display_get_name (gdk_display_get_default ()), TRUE);
 
     /* session management */
-    restart_command = g_new (gchar *, 2);
+    restart_command = g_new (gchar *, 3);
     restart_command[0] = "xfce4-panel";
     restart_command[1] = "-r";
     restart_command[2] = NULL;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20070415/d1536e1f/attachment.pgp>