Bug with panel launcher / exo-open

[Landry]

Le Fri, 15 Sep 2006 15:38:04 +0200,
Mike Massonnet <mmassonnet at gmail.com> a écrit :

> Fri, 15 Sep 2006 15:02:18 +0200 - Benedikt Meurer
> <benedikt.meurer at unix-ag.uni-siegen.de> wrote :
> 
> > Landry wrote:
> > > Hi list,
> > > 
> > > I've just probably found a little bug on current svn, using panel
> > > launchers.
> > > I can't make the launcher running a command with arguments in a
> > > terminal. Example: i put "ncmpc -c" and check 'run in terminal',
> > > and when i click on it, my .xsession-errors shows "exo-open:
> > > Unknown option -c"
> > > Even by adding quotes or double-quotes around the command in the
> > > launcher, i get the same error.
> > > The strange thing is that using exo-open in a command-line, it
> > > works. [16:30:51] lbreuil at begbie:~/ $exo-open --launch
> > > TerminalEmulator ncmpc -c exo-open: Unknown option -c.
> > > [16:43:12] lbreuil at begbie:~/ $exo-open --launch TerminalEmulator
> > > "ncmpc -c"
> > > [launches a terminal with ncmpc -c as command]
> > > 
> > > Where does this come from ? launcher code ? exo-open code ? Am i
> > > missing something ?
> > 
> > Ah, meh, GOption. The panel should probably use
> > 
> >  exo-open --launch TerminalEmulator 'ncmpc -c'
> 
>   Xfce4-panel uses xfterm4 -e ... to execute a shell command.  I had a
> little bug in xfterm4 (the string command wasn't quoted == exo-open:
> unknown option -c), but everything works fine now.  I attach the
> patch, benny can you commit it?
> 
>   Landry, you should run the command fine if you apply the patch over
> xfterm4.
Sorry, didn't see your answer before mine. With this modification, it
works... but i feel libxfcegui4 removing quotes while xfterm4 adds them
is an ugly thing... :)

Landry