Bug with panel launcher / exo-open

[Landry]

Le Fri, 15 Sep 2006 15:02:18 +0200,
Benedikt Meurer <benedikt.meurer at unix-ag.uni-siegen.de> a écrit :

> Landry wrote:
> > Hi list,
> > 
> > I've just probably found a little bug on current svn, using panel
> > launchers.
> > I can't make the launcher running a command with arguments in a
> > terminal. Example: i put "ncmpc -c" and check 'run in terminal', and
> > when i click on it, my .xsession-errors shows "exo-open: Unknown
> > option -c"
> > Even by adding quotes or double-quotes around the command in the
> > launcher, i get the same error.
> > The strange thing is that using exo-open in a command-line, it
> > works. [16:30:51] lbreuil at begbie:~/ $exo-open --launch
> > TerminalEmulator ncmpc -c exo-open: Unknown option -c.
> > [16:43:12] lbreuil at begbie:~/ $exo-open --launch TerminalEmulator
> > "ncmpc -c"
> > [launches a terminal with ncmpc -c as command]
> > 
> > Where does this come from ? launcher code ? exo-open code ? Am i
> > missing something ?
> 
> Ah, meh, GOption. The panel should probably use
> 
>  exo-open --launch TerminalEmulator 'ncmpc -c'
> 
> instead.
From what i understood reading launcher.c, it uses xfterm4 -e 'command'
in a call to xfce_exec_on_screen() in
libxfcegui4/libxfcegui4/xfce-exec.c, which then calls
xfce_exec_create_argv(), and this functions removes quotes around the
command. (lines 228->235).
Apparently, xfterm4 calls exo-open --launch TerminalEmulator (only if
available i suppose) with the command given, but without the quotes.

So, where is the good place to fix this ? 
Landry

Ps: i'm learning more and more about xfce reading this code :)