Xarchiver 0.4.6 released

[Christoph Wickert]

Am Montag, den 27.11.2006, 11:40 +0100 schrieb Giuseppe Torelli:
> Hi,
> 
> just a small change for fixing the icon loading when installing
> Xarchiver and to make pngs filename a bit more freedesktop compliant.
> 

While packaging this for Fedora Extras, some things we noticed:

Quoting from:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217311#c4

> Also reading
> src/deb.c, it seems to me that the files in /tmp are not safely
> created, opening the possibility of a symlink in tmp attack. Maybe
> the manipulation should be done in a /tmp subdir. I haven't checked
> the other /tmp use, some look clearly right, for others there is
> a need to look at the code.

Can somebody please look at this, the code in deb.c looks a little
suspicious.


> $ ldd -u -r /usr/bin/xarchiver 
> Unused direct dependencies:
> 
>         /usr/lib/libatk-1.0.so.0
>         /lib/libm.so.6
>         /usr/lib/libpangocairo-1.0.so.0
>         /usr/lib/libpango-1.0.so.0
>         /usr/lib/libcairo.so.2
>         /lib/libgmodule-2.0.so.0
>         /lib/libdl.so.2

Is this a fedora thing or does it look the same for you?


- add some more mimetypes to xarchiver.desktop?
      * application/x-deb
      * application/x-cd-image
      * application/x-rpm
      * application/x-lha
      * application/x-lhz

- I patched src/callback.c to use htmlview by default. This fires up the
browser from Gnome's "preferred applications" (at least on Fedora/Red
Hat). The patch also includes epiphany, konqueror and seamonkey.

You can follow the review at
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217311

Christoph

> Giuseppe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xarchiver-0.4.6-htmlview.patch
Type: text/x-patch
Size: 876 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20061129/e97c1cc4/attachment.bin>