DnD from xarchiver to thunar makes thunar segfault.

[Stephan Arts]

On 5/30/06, Benedikt Meurer <benedikt.meurer at unix-ag.uni-siegen.de> wrote:
> Stephan Arts wrote:
> >>>>It's a bug in xarchiver, which sends a path instead of a filename with
> >>>>XDS. But of course, Thunar shouldn't crash. I'll fix the crash.
> >>>
> >>>But the filename is correctly extracted. So what is wrong ?
> >>
> >>As the log message
> >>
> >> (thunar:31137): thunar-vfs-CRITICAL **: thunar_vfs_path_relative:
> >>assertion `strchr (name, '/') == NULL' failed
> >>
> >>tells, the filename sent by xarchiver contains a slash (/), which means
> >>it's a path rather than a file name.
> >
> > i think you'd better check if the basename == the filename, because
> > theoretically you could have escaped slashes in the filename.
>
> The slash character is reserved as dir separator, and cannot be part of
> any filename. There's no way to "escape" a slash character.

ok.

Revision 21909 does not compile properly with -Werror because of a
signedness warning.

this patch fixes it.

> Benedikt

Stephan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: thunar-signed-warning-fix.patch
Type: text/x-patch
Size: 748 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20060530/a77b4e09/attachment.bin>