DnD from xarchiver to thunar makes thunar segfault.

[Benedikt Meurer]

Stephan Arts wrote:
> when i open an archive in xarchiver (tar.gz), and i drag a file from
> it and drop it in thunar, thunar segfaults.
> 
> gdb run:
>   Starting program: /usr/local/bin/thunar
>   [Thread debugging using libthread_db enabled]
>   [New Thread -1218344192 (LWP 31137)]
>   [New Thread -1220473936 (LWP 31140)]
>   [New Thread -1228862544 (LWP 31141)]
>   [New Thread -1237251152 (LWP 31142)]
>   [Thread -1237251152 (LWP 31142) exited]
>   [Thread -1228862544 (LWP 31141) exited]
>   [Thread -1220473936 (LWP 31140) exited]
> 
>   (thunar:31137): thunar-vfs-CRITICAL **: thunar_vfs_path_relative:
> assertion `strchr (name, '/') == NULL' failed
> 
>   (thunar:31137): thunar-vfs-CRITICAL **: thunar_vfs_path_dup_uri:
> assertion `path != NULL' failed
> 
>   Program received signal SIGSEGV, Segmentation fault.
>   [Switching to Thread -1218344192 (LWP 31137)]
>   0xb777c203 in strlen () from /lib/tls/libc.so.6
> 
> 
> gdb backtrace:
>   #0  0xb77a1203 in strlen () from /lib/tls/libc.so.6
>   #1  0x080a6bc2 in thunar_standard_view_drag_drop (view=0x81b5008,
>       context=0x821c410, x=22, y=408, time=0, standard_view=0x81ac0c8)
>       at thunar-standard-view.c:2554
>   #2  0xb7d35d6c in _gtk_marshal_BOOLEAN__OBJECT_INT_INT_UINT ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #3  0xb7a06a5b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
>   #4  0xb7a1674d in g_signal_stop_emission () from /usr/lib/libgobject-2.0.so.0
>   #5  0xb7a178e5 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
>   #6  0xb7a1b164 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
>   #7  0xb7cbab3b in _gtk_drag_source_handle_event ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #8  0xb7cb839d in gtk_drag_set_default_icon ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #9  0xb7cb843e in gtk_drag_set_default_icon ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #10 0xb7cb843e in gtk_drag_set_default_icon ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #11 0xb7cb843e in gtk_drag_set_default_icon ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #12 0xb7cb843e in gtk_drag_set_default_icon ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #13 0xb7cb843e in gtk_drag_set_default_icon ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #14 0xb7cb843e in gtk_drag_set_default_icon ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #15 0xb7cb8579 in _gtk_drag_dest_handle_event ()
>      from /usr/lib/libgtk-x11-2.0.so.0
>   #16 0xb7d3415c in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
>   #17 0xb7bb93aa in _gdk_events_queue () from /usr/lib/libgdk-x11-2.0.so.0
>   #18 0xb798e691 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
>   #19 0xb79919d7 in g_main_context_check () from /usr/lib/libglib-2.0.so.0
>   #20 0xb7991f28 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
>   #21 0xb7d332a1 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
>   #22 0x0805c3c0 in main (argc=1, argv=0xbf989c64) at main.c:239
> 
> Is this just a thunar bug, or a bug in both xarchiver and thunar?

It's a bug in xarchiver, which sends a path instead of a filename with
XDS. But of course, Thunar shouldn't crash. I'll fix the crash.

> Stephan

Benedikt