OpenSolaris and Xfce

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martti Kuparinen wrote:
> Does this look reasonable to include in the official Xfce? I'm going to add this
> in the pkgsrc tree...
> 
> http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=33027

I'm ok with it, though all the "test -f" for looking for binaries should
be "test -x".

As for the 'id' issue, I'd rather one of these two:

if test "x$UID" = "x"; then
    if test -x /usr/xpg4/bin/id; then
        UID=`/usr/xpg4/bin/id -u`
    else
        UID=`id -u`
    fi
fi

... or...

if test "x$UID" = "x"; then
    OPSYS="`uname -s`"
    case "$OPSYS" in
        *SunOS*)
            UID=`/usr/xpg4/bin/id -u`
            ;;
        *)
            UID=`id -u`
            ;;
    esac
fi

I'd prefer the former since it's easier to read and obviouser, and
doesn't rely on a silly OS string when it doesn't need to.  I think it's
safe to say that if there's a /usr/xpg4/, it's the right 'id' to use.

Oh, and also, all the way down near the bottom of the patch, it should
be testing $panel, not $xfcesm.

	-brian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEHk2u6XyW6VEeAnsRAh9XAJ95w6L9+F3NxZr4PIbvawwLCJzuQwCdECB7
FpMv8nGNTUKE9l76Db3SYgw=
=ZciK
-----END PGP SIGNATURE-----