xfdesktop feature freeze

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

SJM Arts wrote:

> Brian Tarricone wrote:
>
>> SJM Arts wrote:
>> 
>>> Most of the memory-leaks are not in the xfdesktop-code. But in
>>> thunar or libxfce4util.
>> 
>> That seems a bit unlikely, but I'd be interested in seeing the full
>>  valgrind log.
> 
> Here it is.

Hmm, not really seeing anything in there that would be a memory leak in
xfdesktop.  There are possibly some problems in the menu code, but I'm
not sure, and unfortunately the function names and .c lines are missing
from the call stack (probably since it's a dynamically loaded module).

>>> There are some _init functions that do not have a _destroy 
>>> counterpart, so as a result the memory allocated there isn't
>>> free- ed until the application terminates.
>>
>> Could you be a bit more specific?
> 
> xfce_kiosk_init() allocates a gchar *username and a gchar **groups. 
> But it isn't freed anywhere, same goes somewhere else. But cant find
> it atm.

Yep.  They're intended to be cached for the app's lifetime, at least
from what I can tell from reading the code.  IOW, it's an intentional
"leak".

	-brian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEGBou6XyW6VEeAnsRApCNAJ9WZfX6LZg9lobiAXcU8Wfb4VHOYQCgyZVZ
dOUZtcoK7q0S0P3jDRHkUJw=
=NYzJ
-----END PGP SIGNATURE-----