icon theme changes
Brian J. Tarricone
bjt23 at cornell.edu
Fri Feb 24 20:28:47 CET 2006
-----BEGIN PGP SIGNED MESSAGE-----
Jasper Huijsmans wrote:
> Brian J. Tarricone schreef:
>>Earlier this evening I replaced the XfceIconTheme stuff in the
>>xfce_themed_icon_*() convenience functions with GtkIconTheme calls plus
>>a little crap to make GtkIconTheme a little less picky about icon names.
>>I plan to turn XfceIconTheme into a simple proxy object for GtkIconTheme
>>and leave it in place solely for backward compatibility. All Xfce apps
>>should eventually be changed to either use GtkIconTheme directly, or the
>>xfce_themed_icon_*() convenience functions, and XfceIconTheme should not
>>be used *at all*. I'll be reimplementing the category lookup
>>functionality as convenience functions along side the other
>>xfce_themed_icon_*() stuff. If you don't get around to fixing this for
>>your particular app, no worries: XfceIconTheme will still work in 4.4.
>>Anyway, it's somewhat likely that some icons in some apps that were
>>found before might stop being found. If so, please file a bug (feel
>>free to assign it to me) and let me know specifically which icon in
>>which application. The more specific the better. The desktop menu
>>seems ok so far, so I'm not overly worried.
>>I know it may not be the best idea to be making a change like this right
>>now, but I think it's worth it, and the risk is relatively low.
> It's a great idea if you ask me, and fairly low-risk (compared to other
> changes like a complete panel rewrite ;-)
Hehe, though you at least didn't start the panel rewrite while we're
trying to stabilise for 4.4. Anyway, good to have your support.
The nice thing about this is that GtkIconTheme (in recent gtk versions,
at least) is able to use the binary icon cache to speed things up a bit,
though it's unclear as to whether or not icon rendering takes up the
more time than icon lookup. Anyway, it's mostly done, so...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the Xfce4-dev