[Xfce4-commits] r19947 - in xfce-utils/trunk: . xfrun

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Olivier Fourdan wrote:
> Brian,
> 
> Brian Tarricone wrote:
> 
>> Log:
>> * make xfrun4 not need to link to libxfcegui4, which also removes the link
>>   to libstartup-notification.  might load a tiny bit faster now.  code size
>>   has only a marginal increase.  it would be nice to try to statically link
>>   only libxfce4util, as we only use a tiny bit of it.  unfortunatly libtool
>>   tries to statically link everything.  oh well.
> 
> I really don't think this is a good idea to duplicate portions of 
> libxfcegui4 in xfrun. xfrun is not such an important tool so that it's 
> worth the few nanoseconds it may provide...

Eh, it's just a few things:
xfce_gtk_window_center_on_monitor_with_pointer()
xfce_create_mixed_button()
xfce_exec_on_screen()
xfce_message_dialog()

The first two are pretty trivial, and I implemented hugely-simplified
versions of the latter two since I didn't need most of their generic
features.  They'll probably never need to change (yeah, I know, I just
jinxed it).  No more than 100 lines of code or so.  The nice bit is that
we lose dependencies on libxfcegui4, libstartup-notification, libSM, and
libICE.  Not too shabby.  The final stripped xfrun4 ends up being 20kB
on my system, with 31 linked shared libraries.  Which is still probably
more than it *really* needs, but I don't think there's a way to reduce
that number.

Is the gain huge?  I don't know.  Maybe not.  But the point is that
there really isn't anything lost by doing it this way, so why not?  It's
already done, so I see no reason not to leave it.

	-brian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD93Wd6XyW6VEeAnsRAoq4AJ9WmLFmTtW068oH1cL6LPkZTFHcAACeOFHD
6gdkFoMoACB4Mh5pN4H/7wg=
=EYC9
-----END PGP SIGNATURE-----