Deprecating xfce_setenv()/xfce_putenv() [WAS: [Xfce-i18n]: new subdirectory in orage]

Benedikt Meurer benedikt.meurer at unix-ag.uni-siegen.de
Sun Apr 30 23:14:12 CEST 2006


Olivier Fourdan wrote:
>>>I think this should be deprecated in favor of 
>>>g_getenv()/g_setenv()/g_unsetenv() which are in glib since 2.4.
>>>
>>>we now require gtk+/glib 2.6 as a minimum, so xfce_putenv() is superfluous.
>>
>>Last time I checked g_setenv() still leaked memory on some platforms,
>>that's why xfce_setenv()/xfce_putenv() is not deprecated.
> 
> Well, I'm still in favor of deprecating xfce_setenv()/xfce_putenv() and 
> file a bug to the glib developers if the code in glib is buggy.
> 
> I don't think we should just maintain duplicated functionalities for all 
> buggy parts of glib/gtk+...

Right. But for now, just use xfce_setenv()/xfce_putenv(). We can change
that to g_setenv() once its fixed (or just #define xfce_setenv to g_setenv).

> Cheers,
> Olivier.

Benedikt



More information about the Xfce4-dev mailing list