mcs-manager dialog too wide

Adriano Winter Bess awbess at gmail.com
Sat Apr 1 19:48:21 CEST 2006


Hi,

I've been updating some pt_BR translations for Xfce trunk and I'm concerned
about the width of the xfce-mcs-manager dialog. It seems to me that every button
is given the size of the biggest one (which sounds consistent), but in pt_BR it
turns out that the whole dialog gets very wide (and ugly).

So I decided to start wrapping the text for some of the plugin labels and things
started to look much better. The problem is that the labels are not justified
center (I think this is the way it should look like), so I had to make a wild
guess to make sure it "looked" justified center:

#: ../mcs-plugin/plugin.c:109 ../mcs-plugin/plugin.c:150
msgid "Workspaces and Margins"
msgstr ""
"Áreas de Trabalho\n"
"       e Margens"
#^^^^^^^ -> my guess to make it "look" like it's justified center

I think it would be better if this was adjusted in the mcs-manager dialog, so
translators would be able to simply brake long strings if they think it's
necessary (without the need to guess how much white space is necessary to make
it look justified center). Please see the patch attached.

What do you think about this?

Regards,
Adriano
-- 
Adriano Winter Bess

-------------- next part --------------
Index: xfce-mcs-manager/xfce-mcs-dialog.c
===================================================================
--- xfce-mcs-manager/xfce-mcs-dialog.c	(revisão 20673)
+++ xfce-mcs-manager/xfce-mcs-dialog.c	(cópia de trabalho)
@@ -112,6 +112,7 @@
 
     label = gtk_label_new (text);
     gtk_widget_show (label);
+    gtk_label_set_justify (GTK_LABEL (label), GTK_JUSTIFY_CENTER);
     gtk_label_set_line_wrap (GTK_LABEL (label), TRUE);
     gtk_box_pack_start (GTK_BOX (vbox), label, FALSE, FALSE, 0);
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20060401/b6cacaad/attachment.pgp>


More information about the Xfce4-dev mailing list