Latest Exp Panel segfaulting

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 9/20/2005 11:55 PM, Jasper Huijsmans wrote:
> Biju Chacko schreef:
> 
>>This fixes it
>>
>>Index: panel/panel-item-manager.c
>>===================================================================
>>--- panel/panel-item-manager.c  (revision 17710)
>>+++ panel/panel-item-manager.c  (working copy)
>>@@ -218,7 +218,7 @@
>>          dirs = xfce_resource_dirs (XFCE_RESOURCE_DATA);
>>      }
>>
>>-    for (d = dirs; *d != NULL || !datadir_used; ++d)
>>+    for (d = dirs; *d != NULL && !datadir_used; ++d)
>>      {
>>          GDir *gdir;
>>          char *dirname;
>>
> 
> 
> Unfortunately, this is wrong. I _really_ don't understand why that would 
> work.
> 
> The goal of this code is to make sure that the installation prefix is 
> searched even when it is not part of the resource directories.
> 
> How about this?
> 
> Index: panel-item-manager.c
> ===================================================================
> --- panel-item-manager.c        (revision 17710)
> +++ panel-item-manager.c        (working copy)
> @@ -274,6 +274,9 @@
> 
>           g_free (dirname);
>           g_dir_close (gdir);
> +
> +        if (*d == NULL)
> +            break;
>       }
> 
>       g_strfreev (dirs);

How about you just use xfce_resource_push_path() with PREFIX or
somesuch?  Though of course if it's already in the list, then that could
be annoying.  Meh.

	-b

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)

iD8DBQFDMRvs6XyW6VEeAnsRAusOAKDAhJnOfIjCoXHlz02H23LwCMvdxwCcDfKK
kBEki8O7L9IHufM6ll2ozRU=
=pXAS
-----END PGP SIGNATURE-----