Latest Exp Panel segfaulting

Jasper Huijsmans jasper at xfce.org
Wed Sep 21 09:31:43 CEST 2005


Biju Chacko schreef:
...
>>
>>Unfortunately, this is wrong. I _really_ don't understand why that would 
>>work.

Well, that was before I thought of the fix, of course ;-)

> 
> 
> That would only work if xfce_resource_dirs() returns a valid list. If it 
> returned NULL, then even the install prefix wouldn't be checked. So 
> you're right, '&&' is wrong.
> 

Yeah, the problem was the code was still incrementing 'd' when *d was 
NULL (passed the end of the array). Very bad.

...
> 
> 
> Much better. Works correctly, unlike the previous fix -- which resulted 
> in a weird empty panel thingy which I was debugging. Though I suspect 
> that was due to some other issue.

Great. Thanks for testing.

	Jasper



More information about the Xfce4-dev mailing list