Latest Exp Panel segfaulting

[Biju Chacko]

This fixes it

Index: panel/panel-item-manager.c
===================================================================
--- panel/panel-item-manager.c  (revision 17710)
+++ panel/panel-item-manager.c  (working copy)
@@ -218,7 +218,7 @@
          dirs = xfce_resource_dirs (XFCE_RESOURCE_DATA);
      }

-    for (d = dirs; *d != NULL || !datadir_used; ++d)
+    for (d = dirs; *d != NULL && !datadir_used; ++d)
      {
          GDir *gdir;
          char *dirname;




Biju Chacko wrote:
> Hi Jas,
> 
> The panel (rev. 17710) is segfaulting for me. Here's a run with debug 
> messages enabled. The last DBG output looks a little goofy, perhaps that 
> could be it.
> 
> -- b
> 
> 
> rincewind: gdb /opt/xfce4-exp/bin/xfce4-panel
> GNU gdb Red Hat Linux (6.3.0.0-1.21rh)
> Copyright 2004 Free Software Foundation, Inc.
> GDB is free software, covered by the GNU General Public License, and you are
> welcome to change it and/or distribute copies of it under certain 
> conditions.
> Type "show copying" to see the conditions.
> There is absolutely no warranty for GDB.  Type "show warranty" for details.
> This GDB was configured as "i386-redhat-linux-gnu"...Using host 
> libthread_db library "/lib/libthread_db.so.1".
> 
> (gdb) run
> Starting program: /opt/xfce4-exp/bin/xfce4-panel
> Reading symbols from shared object read from target memory...done.
> Loaded system supplied DSO at 0x94f000
> [Thread debugging using libthread_db enabled]
> [New Thread -1208874528 (LWP 12199)]
> DBG[panel-item-manager.c:244] xfce_panel_item_manager_init():  + 
> directory: /home/botsie/.local/share/xfce4/panel-plugins
> DBG[panel-item-manager.c:244] xfce_panel_item_manager_init():  + 
> directory: /opt/xfce4/share/xfce4/panel-plugins
> DBG[panel-item-manager.c:244] xfce_panel_item_manager_init():  + 
> directory: /usr/local/share/xfce4/panel-plugins
> DBG[panel-item-manager.c:244] xfce_panel_item_manager_init():  + 
> directory: /usr/share/xfce4/panel-plugins
> DBG[panel-item-manager.c:244] xfce_panel_item_manager_init():  + 
> directory: /opt/xfce4-exp//share/xfce4/panel-plugins
> DBG[panel-item-manager.c:134] _new_plugin_class_from_desktop_file(): 
> Plugin .desktop file: 
> /opt/xfce4-exp//share/xfce4/panel-plugins/testplugin.desktop
> DBG[panel-item-manager.c:152] _new_plugin_class_from_desktop_file(): 
> External plugin: /opt/xfce4-exp//libexec/xfce4/panel-plugins/testplugin
> DBG[panel-item-manager.c:123] _plugin_name_from_filename():  ++ name: 
> testplugin
> DBG[panel-item-manager.c:268] xfce_panel_item_manager_init():  + class 
> "testplugin": name=Test Plugin, comment=This plugin has no purpose, 
> icon=xfce-unknown, external=1, 
> path=/opt/xfce4-exp//libexec/xfce4/panel-plugins/testplugin
> DBG[panel-item-manager.c:134] _new_plugin_class_from_desktop_file(): 
> Plugin .desktop file: 
> /opt/xfce4-exp//share/xfce4/panel-plugins/tasklist.desktop
> DBG[panel-item-manager.c:163] _new_plugin_class_from_desktop_file(): 
> Internal plugin: /opt/xfce4-exp//lib/xfce4/panel-plugins/libtasklist.so
> DBG[panel-item-manager.c:123] _plugin_name_from_filename():  ++ name: 
> tasklist
> DBG[panel-item-manager.c:268] xfce_panel_item_manager_init():  + class 
> "tasklist": name=Tasklist, comment=Show all running applications, 
> icon=xfce4-taskbar, external=0, 
> path=/opt/xfce4-exp//lib/xfce4/panel-plugins/libtasklist.so
> DBG[panel-item-manager.c:134] _new_plugin_class_from_desktop_file(): 
> Plugin .desktop file: 
> /opt/xfce4-exp//share/xfce4/panel-plugins/pager.desktop
> DBG[panel-item-manager.c:163] _new_plugin_class_from_desktop_file(): 
> Internal plugin: /opt/xfce4-exp//lib/xfce4/panel-plugins/libpager.so
> DBG[panel-item-manager.c:123] _plugin_name_from_filename():  ++ name: pager
> DBG[panel-item-manager.c:268] xfce_panel_item_manager_init():  + class 
> "pager": name=Pager, comment=Miniature view of all virtual desktops, 
> icon=xfce4-taskbar, external=0, 
> path=/opt/xfce4-exp//lib/xfce4/panel-plugins/libpager.so
> DBG[panel-item-manager.c:134] _new_plugin_class_from_desktop_file(): 
> Plugin .desktop file: 
> /opt/xfce4-exp//share/xfce4/panel-plugins/actions.desktop
> DBG[panel-item-manager.c:163] _new_plugin_class_from_desktop_file(): 
> Internal plugin: /opt/xfce4-exp//lib/xfce4/panel-plugins/libactions.so
> DBG[panel-item-manager.c:123] _plugin_name_from_filename():  ++ name: 
> actions
> DBG[panel-item-manager.c:268] xfce_panel_item_manager_init():  + class 
> "actions": name=Panel Actions, comment=Log out or lock the screen, 
> icon=xfce4-panel, external=0, 
> path=/opt/xfce4-exp//lib/xfce4/panel-plugins/libactions.so
> DBG[panel-item-manager.c:134] _new_plugin_class_from_desktop_file(): 
> Plugin .desktop file: 
> /opt/xfce4-exp//share/xfce4/panel-plugins/launcher.desktop
> DBG[panel-item-manager.c:163] _new_plugin_class_from_desktop_file(): 
> Internal plugin: /opt/xfce4-exp//lib/xfce4/panel-plugins/liblauncher.so
> DBG[panel-item-manager.c:123] _plugin_name_from_filename():  ++ name: 
> launcher
> DBG[panel-item-manager.c:268] xfce_panel_item_manager_init():  + class 
> "launcher": name=Launcher, comment=Program launcher with optional menu, 
> icon=gnome-fs-executable, external=0, 
> path=/opt/xfce4-exp//lib/xfce4/panel-plugins/liblauncher.so
> DBG[panel-item-manager.c:134] _new_plugin_class_from_desktop_file(): 
> Plugin .desktop file: 
> /opt/xfce4-exp//share/xfce4/panel-plugins/separator.desktop
> DBG[panel-item-manager.c:163] _new_plugin_class_from_desktop_file(): 
> Internal plugin: /opt/xfce4-exp//lib/xfce4/panel-plugins/libseparator.so
> DBG[panel-item-manager.c:123] _plugin_name_from_filename():  ++ name: 
> separator
> DBG[panel-item-manager.c:268] xfce_panel_item_manager_init():  + class 
> "separator": name=Separator, comment=Adds a space or a line between 
> panel items, icon=xfce4-panel, external=0, 
> path=/opt/xfce4-exp//lib/xfce4/panel-plugins/libseparator.so
> DBG[panel-item-manager.c:244] xfce_panel_item_manager_init():  + 
> directory: plu/xfce4/panel-plugins
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread -1208874528 (LWP 12199)]
> 0x08050a8e in xfce_panel_item_manager_init () at panel-item-manager.c:236
> 236                 if (strcmp (DATADIR, *d) == 0)
> (gdb) bt
> #0  0x08050a8e in xfce_panel_item_manager_init () at 
> panel-item-manager.c:236
> #1  0x0804efac in panel_app_run (argc=1, argv=0xbfb4a6f4) at panel-app.c:410
> #2  0x0804e7fe in main (argc=1, argv=0xbfb4a6f4) at main.c:164
> (gdb)
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://foo-projects.org/mailman/listinfo/xfce4-dev
>