Aw: Re: New panel in trunk

[Jasper Huijsmans]

Fabian Nowak schreef:
> hmm, launcher is still not better than before. try this:
> 
> :~/tmp/xfce4-panel/plugins/launcher$ diff launcher.c launcher_fabian.c 
> 801a802,803
> 
>>    else 
>>        entry->name = g_strdup ("");
> 
> 804a807,808
> 
>>    else
>>        entry->exec = g_strdup ("");
> 
> 811a816,817
> 
>>    else 
>>        entry->comment = g_strdup ("");
> 
> 812a819,821
> 
>>/* be careful: what about having no icon specified? it will try
>>    to read x-fce-icon-category!
>>    so FIXME! */
> 
> 
> 
> Works.
> 

This is the wrong fix IMO. What exactly does it solve (what works 
afterwards that didn't work before)?

[...]
>>>
>>>
>>>>>got the impression you check for unknown commands only when reading the
>>>>>config files?
>>>>
>>>>As far as I know, I don't check anything...
>>>>
>>>>	Jasper
> 
> 
> true. there is no signal handler registered:
> 
> 
> launcher_dialog_response (OK) ->  launcher_save(plugin , launcher) ->
> launcher_write_rc_file (..) -> 
> 
> i suggest adding 
> 
> g_signal_connect (mi, "activate", G_CALLBACK
> (launcher_menu_item_activate), entry); to launcher_save() after writing
> the rc file.
> 
> then you have the signal handler. but i'm too lazy to search around on
> whether plugin or launcher has this 'entry' to be given as parameter.
> 

Huh?? This doesn't make any sense. What's this 'mi'. What are you trying 
to do?