kiosk settings naming inconsistency

Brian J. Tarricone bjt23 at cornell.edu
Tue Nov 8 21:15:19 CET 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/8/2005 10:17 AM, Jani Monoses wrote:
> Jani Monoses wrote:
> 
>>Hi
>>sorry about not being clear
>>I had to make these changes so that the [xfce4-session] related entries 
>>in kioskrc are taken into consideration ( if they are written according 
>>to the documentation)
>>
>>--- xfce4-session-4.2.2.orig/settings/session/session.c
>>+++ xfce4-session-4.2.2/settings/session/session.c
>>@@ -318,10 +318,10 @@
>>    xfce_textdomain (GETTEXT_PACKAGE, PACKAGE_LOCALE_DIR, "UTF-8");
>>
>>    kiosk = xfce_kiosk_new ("xfce4-session");
>>-  kiosk_can_chooser = xfce_kiosk_query (kiosk, "Chooser");
>>-  kiosk_can_logout = xfce_kiosk_query (kiosk, "Logout");
>>-  kiosk_can_compat = xfce_kiosk_query (kiosk, "Compatibility");
>>-  kiosk_can_security = xfce_kiosk_query (kiosk, "Security");
>>+  kiosk_can_chooser = xfce_kiosk_query (kiosk, "CustomizeChooser");
>>+  kiosk_can_logout = xfce_kiosk_query (kiosk, "CustomizeLogout");
>>+  kiosk_can_compat = xfce_kiosk_query (kiosk, "CustomizeCompatibility");
>>+  kiosk_can_security = xfce_kiosk_query (kiosk, "CustomizeSecurity");
>>    xfce_kiosk_free (kiosk);
>>    tooltips = gtk_tooltips_new ();
>>
>>only in patch2:
>>unchanged:
>>--- xfce4-session-4.2.2.orig/settings/splash/splash.c
>>+++ xfce4-session-4.2.2/settings/splash/splash.c
>>@@ -367,7 +367,7 @@
>>
>>    /* query kiosk settings */
>>    kiosk = xfce_kiosk_new ("xfce4-session");
>>-  kiosk_can_splash = xfce_kiosk_query (kiosk, "Splash");
>>+  kiosk_can_splash = xfce_kiosk_query (kiosk, "CustomizeSplash");
>>    xfce_kiosk_free (kiosk);
>>
>>    /* load config */
> 
> 
> This still seems to be present in both the 4.2 branch and trunk
> I think either this patch is needed or the documentation clarified to 
> say that kioskrc for session is not to use keywords with the Customize 
> prefix.

The preferred place to post patches is on bugzilla.xfce.org, otherwise
they tend to get forgotten as seems to be the case here.

	-brian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)

iD8DBQFDcQdX6XyW6VEeAnsRAjP2AJ9+BE1kjGRKzGfzgkrZeWaRDR5M9gCfZpsK
nOmmyp6XKllUfmp6tXoXj4o=
=z1wZ
-----END PGP SIGNATURE-----



More information about the Xfce4-dev mailing list