menu plugin oddity

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Pasi Orovuo wrote:
> Hi,
> 
> On Thu, Nov 03, 2005 at 04:55:53PM +0530, Biju Chacko wrote:
> 
>>Brian J. Tarricone wrote:
>>
>>>-----BEGIN PGP SIGNED MESSAGE-----
>>>Hash: SHA1
>>>
>>>Biju Chacko wrote:
>>>
>>>
>>>>Hi,
>>>>
>>>>With my latest build of svn trunk, the menu plugin has stopped 
>>>>displaying the icon properly.
>>>
>>>
>>>Define "properly".  Screenshots help too.
>>
>>s/properly//.
>>
>>ie. No icon at all. Plugin is resized to minimum height (I use a 
>>vertical panel). Still works fine if you click on it. Text Label appears 
>>if you enable it.
>>
> I just last night upgraded xfdesktop, and am experiencing the same
> problem. The reason for this is indeed in the non-square icon stuff,
> as Brian suspected. gtk_pixbuf_new_from_file_at_scale() does not allow
> negative (don't constrain the size) width/height values on Gtk+ 2.6, and
> thus fails. The simple fix is to change the #ifdef's to match Gtk+ 2.8
> (see attached patch), but Brian might want to do other magic as well.

Good call.  Thanks for saving me some time; committed.  No need for
magic if the simple solution works ^_^.

	-b

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDbdce6XyW6VEeAnsRAsRhAKDufgP4GmAUcjKvA8wXC3wpHTbiagCg2P58
dwaTRvBB6/Lq7Z6ti5FZK7E=
=ZqBU
-----END PGP SIGNATURE-----